complete function snippets #701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zth
commented
Jan 18, 2023
| @@ -1119,7 +1119,7 @@ function onMessage(msg: p.Message) { | |||
| renameProvider: { prepareProvider: true }, | |||
| documentSymbolProvider: true, | |||
| completionProvider: { | |||
| triggerCharacters: [".", ">", "@", "~", '"', "="], | |||
| triggerCharacters: [".", ">", "@", "~", '"', "=", "("], | |||
There was a problem hiding this comment.
I added this more as a test. I think we can leave it on in the pre-release version and see what people say. Easy to remove if it's annoying because it triggers completion quite often.
cristianoc
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completes function snippets in positions where a function is expected. I think this is a cool feature that can be quite useful.