Skip to content

break up CompletionBackend and CompletionFrontend into modules #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

zth
Copy link
Collaborator

@zth zth commented Jan 14, 2023

I've just moved things around and tried to move things into sub modules. Should hopefully make the code a bit more approachable. More can be done of course, but I think this is a good start.

@zth zth requested a review from cristianoc January 14, 2023 17:08
Copy link
Collaborator

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nice. I was wondering about what opportunities might arise for introducing code duplication without noticing. But this structure, I think, actually helps with that, as it's quicker to keep track of what functions exist.

@zth zth merged commit b52e268 into master Jan 15, 2023
@zth zth deleted the refactor-separate-modules branch January 15, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants