Skip to content

Remove ".enable" from rescript.settings.codeLens in package.json #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2022
Merged

Remove ".enable" from rescript.settings.codeLens in package.json #534

merged 1 commit into from
Jul 30, 2022

Conversation

Minnozz
Copy link
Contributor

@Minnozz Minnozz commented Jul 30, 2022 •
edited
Loading

The setting is called rescript.settings.codeLens instead of rescript.settings.codeLens.enable.

@Minnozz Minnozz force-pushed the fix-codelens-setting branch from 71a4ed3 to ace8914 Compare July 30, 2022 09:35
@Minnozz Minnozz changed the title Add ".enable" after rescript.settings.codeLens in documentation Remove ".enable" from rescript.settings.codeLens in package.json Jul 30, 2022
@Minnozz
Copy link
Contributor Author

Minnozz commented Jul 30, 2022

Turns out I had it the wrong way around the first time, so I changed the PR.

@zth
Copy link
Member

zth commented Jul 30, 2022

Thank you!

@zth zth merged commit b6efb50 into rescript-lang:master Jul 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Minnozz @zth @BartSchuurmans