Skip to content

fix undefined inlayHints #527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2022
Merged

fix undefined inlayHints #527

merged 1 commit into from
Jul 29, 2022

Conversation

aspeddro
Copy link
Contributor

When then inlayHints.enable is not in initializationOptions

LSP Log:

[ERROR][2022-07-26 17:34:09] .../vim/lsp/rpc.lua:420	"rpc"	"node"	"stderr"	"/home/pedro/Desktop/Projects/rescript-vscode/server/out/server.js:839\n                    inlayHintProvider: extensionConfiguration.inlayHints.enable,\n                                                                         ^\n\nTypeError: Cannot read property 'enable' of undefined\n    at StreamMessageReader.onMessage [as callback] (/home/pedro/Desktop/Projects/rescript-vscode/server/out/server.js:839:74)\n    at /home/pedro/Desktop/Projects/rescript-vscode/server/node_modules/vscode-jsonrpc/lib/common/messageReader.js:162:26\n    at processTicksAndRejections (node:internal/process/task_queues:94:5)\n"

@aspeddro aspeddro closed this Jul 27, 2022
@aspeddro aspeddro reopened this Jul 27, 2022
@aspeddro
Copy link
Contributor Author

This PR contains some fixes that were in #528

@zth zth merged commit e3700a3 into rescript-lang:master Jul 29, 2022
@aspeddro aspeddro deleted the fix-undefined branch December 19, 2022 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aspeddro @zth