Find other binaries via compiler-info.json #1135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojaf
commented
Oct 2, 2025
| } | ||
|
|
||
| const projectRewatchLockfiles = [ | ||
| ...Array.from(workspaceFolders).map((w) => |
There was a problem hiding this comment.
ReScript lock was located at workspace level:
lib/rescript.lock
Was absent on packages/a/lib level, so it assumed bsb and failed.
nojaf
commented
Oct 2, 2025
| "..", | ||
| `@rescript/${target}/bin.js`, | ||
| ); | ||
| const { binPaths } = await import(targetPackagePath); |
There was a problem hiding this comment.
The dynamic import of rescript/../@rescript-platform package fails on pnpm because it is located deeply in the node_module/.pnpm folder.
node_modules/.pnpm/@[email protected]/node_modules/@rescript/darwin-arm64/bin/
So, using the path from compiler-info.json is the better play.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sample in rescript-lang/end-to-end#1
Adds some fixes for #1106
package
ahas acompiler-info.jsonof:{ "version": "12.0.0-beta.13", "bsc_path": "/Users/nojaf/Projects/rescript-end-to-end/repos/pnpm/monorepo/node_modules/.pnpm/@[email protected]/node_modules/@rescript/darwin-arm64/bin/bsc.exe", "bsc_hash": "1263ce9a1dad7e30b855a8221d361b1147c2c1541a3f2600d09e954deb989ae6", "rescript_config_hash": "68d9b6cfd83ac38869b2afe037b4fcbbbb9faa016302a2f26d45a1e7875e1479", "runtime_path": "/Users/nojaf/Projects/rescript-end-to-end/repos/pnpm/monorepo/node_modules/.pnpm/@[email protected]/node_modules/@rescript/runtime", "generated_at": "1759387416473" }