Skip to content

Deprecated more props types #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 1, 2022
Merged

Deprecated more props types #65

merged 2 commits into from
Oct 1, 2022

Conversation

cknitt
Copy link
Member

@cknitt cknitt commented Oct 1, 2022

Deprecate ReactDOM.props, ReactDOM.Props.props, ReactDOM.Props.domProps.

ReactDOM.domProps is the way to go. 🙂

@cknitt cknitt requested a review from mununki October 1, 2022 06:39
mununki
mununki reviewed Oct 1, 2022
View reviewed changes
mununki
mununki approved these changes Oct 1, 2022
View reviewed changes
Copy link
Member

@mununki mununki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I'll test it on my project about using v3 and v4 after being merged!

@cknitt cknitt merged commit 49c4a9b into master Oct 1, 2022
@cknitt cknitt deleted the deprecate-props-types branch October 1, 2022 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

@mununki mununki mununki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cknitt @cristianoc @mununki