Skip to content

Doc: Clear type errors and warnings in the rescript playground where posible #603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 15, 2022
Merged

Doc: Clear type errors and warnings in the rescript playground where posible #603

merged 2 commits into from
Nov 15, 2022

Conversation

kamweti
Copy link
Contributor

@kamweti kamweti commented Nov 14, 2022 •
edited
Loading

fixes #600

@kamweti
- clear type errors and warnings in the rescript playground where pos…
3f80fe8 
…sible

- do not link to playground for some examples
@kamweti kamweti changed the title clear type errors and warnings in the rescript playground where posible Doc: Clear type errors and warnings in the rescript playground where posible Nov 14, 2022
cristianoc
cristianoc reviewed Nov 14, 2022
View reviewed changes
@kamweti kamweti requested a review from cristianoc November 15, 2022 08:15
cristianoc
cristianoc approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix!

@cristianoc cristianoc merged commit 7a2c329 into rescript-lang:master Nov 15, 2022
kamweti
kamweti commented Nov 15, 2022
View reviewed changes
Copy link
Contributor Author

@kamweti kamweti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding prelude in one more place

@kamweti
Copy link
Contributor Author

kamweti commented Nov 15, 2022

@cristianoc 👍🏿

@kamweti kamweti deleted the private/fix-600-1 branch December 29, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianoc cristianoc cristianoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Type errors, Warnings shown in the ReScript Playground for snippets in the Exceptions documentation page
2 participants
@kamweti @cristianoc