Skip to content

Conversation

@brad
Copy link
Contributor

@brad brad commented Jan 24, 2017

This adds a compliance fix for the Fitbit API so that errors that occur during access token or refresh token fetching get properly surfaced.
https://dev.fitbit.com/docs/oauth2/#authorization-errors

We have been using this successfully with the python-fitbit library for a few weeks now: https://github.com/orcasgit/python-fitbit/blob/master/fitbit/compliance.py

@coveralls
Copy link

coveralls commented Jan 24, 2017

Coverage Status

Coverage decreased (-0.06%) to 86.696% when pulling cfc5af9 on orcasgit:fitbit-compliance into 476ba75 on requests:master.

@coveralls
Copy link

coveralls commented Jan 24, 2017

Coverage Status

Coverage decreased (-0.06%) to 86.696% when pulling 3b37810 on orcasgit:fitbit-compliance into 476ba75 on requests:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 86.696% when pulling 3b37810 on orcasgit:fitbit-compliance into 476ba75 on requests:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 86.696% when pulling 3b37810 on orcasgit:fitbit-compliance into 476ba75 on requests:master.

Copy link
Member

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me, thanks @brad! ✨

@Lukasa Lukasa merged commit e1d851d into requests:master Jan 25, 2017
@brad brad deleted the fitbit-compliance branch January 25, 2017 15:55
@brad
Copy link
Contributor Author

brad commented Jan 25, 2017

Thanks @Lukasa!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants