new version Sphinx 4.0 requires this package to be updated

[jugmac00]

Also, tox does not work currently.

❯ tox -e py39 -r
GLOB sdist-make: /home/jugmac00/Projects/repoze.sphinx.autointerface/setup.py
py39 recreate: /home/jugmac00/Projects/repoze.sphinx.autointerface/.tox/py39
py39 installdeps: zope.testrunner
py39 inst: /home/jugmac00/Projects/repoze.sphinx.autointerface/.tox/.tmp/package/1/repoze.sphinx.autointerface-0.8.1.dev0.zip
ERROR: invocation failed (exit code 1), logfile: /home/jugmac00/Projects/repoze.sphinx.autointerface/.tox/py39/log/py39-2.log
=========================================================== log start ============================================================
Processing ./.tox/.tmp/package/1/repoze.sphinx.autointerface-0.8.1.dev0.zip
    ERROR: Command errored out with exit status 1:
     command: /home/jugmac00/Projects/repoze.sphinx.autointerface/.tox/py39/bin/python -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'/tmp/pip-req-build-9ruvlhgg/setup.py'"'"'; __file__='"'"'/tmp/pip-req-build-9ruvlhgg/setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info --egg-base /tmp/pip-pip-egg-info-ppju3j90
         cwd: /tmp/pip-req-build-9ruvlhgg/
    Complete output (5 lines):
    Traceback (most recent call last):
      File "<string>", line 1, in <module>
      File "/tmp/pip-req-build-9ruvlhgg/setup.py", line 24, in <module>
        with open(os.path.join(here, 'CHANGES.rst')) as f:
    FileNotFoundError: [Errno 2] No such file or directory: '/tmp/pip-req-build-9ruvlhgg/CHANGES.rst'
    ----------------------------------------
WARNING: Discarding file:///home/jugmac00/Projects/repoze.sphinx.autointerface/.tox/.tmp/package/1/repoze.sphinx.autointerface-0.8.1.dev0.zip. Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.
WARNING: You are using pip version 21.0.1; however, version 21.1.1 is available.
You should consider upgrading via the '/home/jugmac00/Projects/repoze.sphinx.autointerface/.tox/py39/bin/python -m pip install --upgrade pip' command.

============================================================ log end =============================================================
____________________________________________________________ summary _____________________________________________________________
ERROR:   py39: InvocationError for command /home/jugmac00/Projects/repoze.sphinx.autointerface/.tox/py39/bin/python -m pip install --exists-action w .tox/.tmp/package/1/repoze.sphinx.autointerface-0.8.1.dev0.zip (exited with code 1)

This package currently only supports Python 2.7 and 3.5.

Also, a couple of hours ago Sphinx 4.0 came out with breaks this package.

Extension error:
Could not import extension repoze.sphinx.autointerface (exception: cannot import name 'force_decode' from 'sphinx.util' (/home/runner/work/Products.PluggableAuthService/Products.PluggableAuthService/.tox/docs/lib/python3.8/site-packages/sphinx/util/__init__.py))
ERROR: InvocationError for command /home/runner/work/Products.PluggableAuthService/Products.PluggableAuthService/.tox/docs/bin/sphinx-build -b html -d docs/_build/doctrees docs docs/_build/html (exited with code 2)

[jugmac00]

It is a bit hard to understand the Sphinx documentation, but I interpret

   * - ``sphinx.util.force_decode()``
     - 2.0
     - 4.0
     - N/A

as force_decode was deprecated with Sphinx 2, removed with Sphinx 4 and the last - means there is no replacement.

[stevepiercy]

Your interpretation is correct. Rendered to HTML: https://www.sphinx-doc.org/en/master/extdev/deprecated.html

[stevepiercy]

Here's the PR and explanation for the deprecation.
sphinx-doc/sphinx#5620

[stevepiercy]

What do we want to do? Drop Python 2 support? Pin to Sphinx < 4 or vendor in force_decode?

[icemac]

I'd suggest to drop Python 2 support, it should make the code cleaner here.

[jugmac00]

Also see #13 - the problem was well known for years.

[jugmac00]

I'd suggest to drop Python 2 support, it should make the code cleaner here.

pinging @jamadden who - at least for other packages - wanted to keep Python 2 support for some more time

[icemac]

I see no need to still build the documentation of a package on Python 2.

[jamadden]

Agreed. Sphinx itself dropped support for running on Python 2 some time ago, and projects that support Python 2 also support Python 3 (and so can build their docs with Python 3). So as long as the metadata (python_requires) is set correctly for a new uploaded version of this plugin, there shouldn't be much of an issue with it dropping Python 2.

[jamadden]

#14 was a PR that's been merged which partly fixed this issue when it was originally reported in #13. But there were some issues with that, and according to the comments on #14, @tseaver and @freddrake were going to take a look at things. So master is in a different state than the released plugin and in fact may already have unintentionally dropped support for Python 2.