Support for returning multiple outputs #328
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to return more than one output from Cog, without having to wrap the outputs in a zip file.
Python API changes
The
predict()function treats dict outputs as multiple outputs. This is a change in behavior from before, when dicts were returned as json.You can mix
pathlib.Paths and other non-Path types. The following is a valid response:Server changes
The built-in HTTP server returns multiple outputs as
multipart/form-data.The Redis queue worker returns multiple outputs as a new
multi_valuesfield in the response struct. The response struct now is:UI changes
cog predictcan write multiple outputs to stdout if the outputs are non-Path or textual Path outputs.For example, given the following predict.py:
cog predict -i input=hellooutputs:Non-textual Path outputs are written to files named after the key in the response dict.
If the user passes the
-oflag tocog predict, the outputs get named<output-name>.<dict-key>.<extension>.Signed-off-by: andreasjansson [email protected]