Use hostname for integration tests instead of IP #263
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfirsh
force-pushed
the
use-hostname-for-redis-tests
branch
from
41f6914 to
85331da
Compare
zeke
approved these changes
Sep 28, 2021
Member
Author
|
This works on my local machine but not on CI, lol. I think we need the real fix in #262 unless y'all have any bright ideas for bodges @andreasjansson @zeke. |
This seemed to be relying on some very subtle behavior. It seems that the IP returned as the reverse of the local hostname was a local IP that was just on the host but not inside the container (maybe 127.0.1.1 instead of 127.0.0.1 or something?). Either way this wasn't working due to something about my local network setup and my hostname resolved to 127.0.0.1. This is actually localhost inside the container, hence it couldn't connect to redis. This is a bodge to get this working. Instead of relying on IP addresses, use the hostname which will instead defer to DNS to figure out what the right IP address based on where it is being accessed. But this is still fragile and I spent laods of time debugging! See also: replicate#262 Signed-off-by: Ben Firshman <[email protected]>
bfirsh
force-pushed
the
use-hostname-for-redis-tests
branch
from
85331da to
8aec74a
Compare
bfirsh
added a commit
to bfirsh/cog
that referenced
this pull request
Jan 5, 2022
This is possible now we don't have file upload server. Closes replicate#262 Closes replicate#263 Signed-off-by: Ben Firshman <[email protected]>
bfirsh
added a commit
to bfirsh/cog
that referenced
this pull request
Jan 5, 2022
This is possible now we don't have file upload server. Closes replicate#262 Closes replicate#263 Signed-off-by: Ben Firshman <[email protected]>
bfirsh
added a commit
to bfirsh/cog
that referenced
this pull request
Jan 7, 2022
This is possible now we don't have file upload server. Closes replicate#262 Closes replicate#263 Signed-off-by: Ben Firshman <[email protected]>
bfirsh
added a commit
to bfirsh/cog
that referenced
this pull request
Jan 7, 2022
This is possible now we don't have file upload server. Closes replicate#262 Closes replicate#263 Signed-off-by: Ben Firshman <[email protected]>
bfirsh
added a commit
to bfirsh/cog
that referenced
this pull request
Jan 7, 2022
This is possible now we don't have file upload server. Closes replicate#262 Closes replicate#263 Signed-off-by: Ben Firshman <[email protected]>
bfirsh
added a commit
to bfirsh/cog
that referenced
this pull request
Jan 8, 2022
This is possible now we don't have file upload server. Closes replicate#262 Closes replicate#263 Signed-off-by: Ben Firshman <[email protected]>
bfirsh
added a commit
to bfirsh/cog
that referenced
this pull request
Jan 8, 2022
This is possible now we don't have file upload server. Closes replicate#262 Closes replicate#263 Signed-off-by: Ben Firshman <[email protected]>
36 tasks
bfirsh
added a commit
to bfirsh/cog
that referenced
this pull request
Jan 11, 2022
This is possible now we don't have file upload server. Closes replicate#262 Closes replicate#263 Signed-off-by: Ben Firshman <[email protected]>
bfirsh
added a commit
to bfirsh/cog
that referenced
this pull request
Jan 12, 2022
The queue_controller server has been replaced by a separate container that can run inside the network. Closes replicate#262 Closes replicate#263 Signed-off-by: Ben Firshman <[email protected]>
bfirsh
added a commit
to bfirsh/cog
that referenced
this pull request
Jan 12, 2022
The queue_controller server has been replaced by a separate container that can run inside the network. Closes replicate#262 Closes replicate#263 Signed-off-by: Ben Firshman <[email protected]>
bfirsh
added a commit
to bfirsh/cog
that referenced
this pull request
Jan 12, 2022
The queue_controller server has been replaced by a separate container that can run inside the network. Closes replicate#262 Closes replicate#263 Signed-off-by: Ben Firshman <[email protected]>
bfirsh
added a commit
to bfirsh/cog
that referenced
this pull request
Jan 12, 2022
The queue_controller server has been replaced by a separate container that can run inside the network. Closes replicate#262 Closes replicate#263 Signed-off-by: Ben Firshman <[email protected]>
bfirsh
added a commit
to bfirsh/cog
that referenced
this pull request
Jan 12, 2022
The queue_controller server has been replaced by a separate container that can run inside the network. Closes replicate#262 Closes replicate#263 Signed-off-by: Ben Firshman <[email protected]>
bfirsh
added a commit
to bfirsh/cog
that referenced
this pull request
Jan 13, 2022
The queue_controller server has been replaced by a separate container that can run inside the network. Closes replicate#262 Closes replicate#263 Signed-off-by: Ben Firshman <[email protected]>
bfirsh
added a commit
to bfirsh/cog
that referenced
this pull request
Jan 13, 2022
The queue_controller server has been replaced by a separate container that can run inside the network. Closes replicate#262 Closes replicate#263 Signed-off-by: Ben Firshman <[email protected]>
bfirsh
added a commit
to bfirsh/cog
that referenced
this pull request
Jan 13, 2022
The queue_controller server has been replaced by a separate container that can run inside the network. Closes replicate#262 Closes replicate#263 Signed-off-by: Ben Firshman <[email protected]>
bfirsh
added a commit
to bfirsh/cog
that referenced
this pull request
Jan 15, 2022
The queue_controller server has been replaced by a separate container that can run inside the network. Closes replicate#262 Closes replicate#263 Signed-off-by: Ben Firshman <[email protected]>
bfirsh
added a commit
that referenced
this pull request
Feb 7, 2022
The queue_controller server has been replaced by a separate container that can run inside the network. Closes #262 Closes #263 Signed-off-by: Ben Firshman <[email protected]>
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seemed to be relying on some very subtle behavior. It seems that
the IP returned as the reverse of the local hostname was a local IP that
was just on the host but not inside the container (maybe 127.0.1.1
instead of 127.0.0.1 or something?).
Either way this wasn't working due to something about my local network
setup and my hostname resolved to 127.0.0.1. This is actually localhost
inside the container, hence it couldn't connect to redis.
This is a bodge to get this working. Instead of relying on IP addresses,
use the hostname which will instead defer to DNS to figure out what the
right IP address based on where it is being accessed.
But this is still fragile and I spent laods of time debugging! See also: #262
Signed-off-by: Ben Firshman [email protected]