Elf_section_header_table: fix section ordering #1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the order of ELF sections in
elf_memory_image_of_elf64_fileis reversed. Here is areadelfdump of the object file:And here is what
elf_memory_image_of_elf64_filegets (iis the index of the section, its name is at the end of the line):Since the first section is expected to be null, the function fails. Here, the
last section is the null one.
I tried not to use
appendbut I failed to define an auxiliary, private, recursive helper function that builds the reversed list. Defining a recursive function inside another function doesn't seem to work and defining a recursive helper function above seems to require the helper function to be public. Let me know if there's a better way to do this.Once again, there's some noise due to trailing whitespace.