-
Notifications
You must be signed in to change notification settings - Fork 20
fix(fieldset): support root conditionals for fieldsets #23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sandrina-p
merged 31 commits into
main
from
rmt-517-support-root-conditionals-for-fieldsets
Jul 3, 2023
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
3312f29
create playground to test things
gabrielremote bd02e44
docs(select-validation) - extract options values into an array
gabrielremote 049e9e2
docs(select-validation) - extract options values into an array
gabrielremote be51f44
Merge branch 'main' into rmt-23-jsf-select-validation-is-incomplete
gabrielremote d265ea9
feat(select) - update yupSchema
gabrielremote f2dfe7f
fix(yupSchema) - tests
gabrielremote bc07113
add whitespace to yupSchemas
gabrielremote 7aa64e4
docs(select) - add tests for select
gabrielremote 3ec54ff
remove comments
gabrielremote d0415e9
Merge branch 'main' into rmt-23-jsf-select-validation-is-incomplete
gabrielremote 35c4dd4
add missing assertions
gabrielremote f8a8736
Revert "create playground to test things"
sandrina-p 2d2fdc6
Handle null and empty string. Set custom error message. Add more test…
sandrina-p 58e0efc
Sandrina's self-review
sandrina-p 54e090d
fix the bug with a lot of changes. clean next
sandrina-p 48a60ab
Clean unnecessary changes - commit it for future story
sandrina-p d51ccd2
write test
sandrina-p 1c7ed57
branch-of-branch - verify old option is no longer valid
sandrina-p 5ccfda9
Release 0.4.1-dev.20230702181843
sandrina-p 989d3fd
also allow null in required select/radio fields
sandrina-p 58b2850
Release 0.4.1-dev.20230703082439
sandrina-p fc00b24
fix schema type string -> number
sandrina-p 3b261f6
fix incorrect json schema - default value was invalid
sandrina-p fea8d28
Still allow "null" in conventional empty fields
sandrina-p aa4c2fc
Release 0.4.1-dev.20230703161935
sandrina-p 6679325
handle conditionals that include select fields
sandrina-p 433603a
Release 0.4.1-dev.20230703195833
sandrina-p ec2b2eb
refactor ''/null edge-case to use .transform()
sandrina-p 21d2f64
Release 0.4.1-dev.20230703203242
sandrina-p ecc7d18
Merge remote-tracking branch 'origin' into rmt-517-support-root-condi…
sandrina-p bbd5927
Revert back to 0.4.0-beta.0
sandrina-p File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.