feat: allow accumulator/current in reduce/map operations #225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eng-almeida
reviewed
Aug 20, 2025
cammellos
force-pushed
the
feat/add-reduce
branch
from
c21a437 to
8f12226
Compare
dragidavid
approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of removing some code from the dragon frontend, to be able to use it in our SDK/API, I had to move some frontend logic to the backend.
To do that, I need to use
reduce, in order to calculate the length on a array. This is in theory supported byjson-logic-js.The issue is that we run validation against the data provided, but we don't accommodate for the fact that if we are within a reduce/map block, we should allow
currentandaccumulator.This code enriches the validation data if we are within a reduce/map block, while it maintains checking the integrity of the rest of the variables.
Let me know if the implementation is what you expect or you'd rather be different, thank you!