fix(conditionals): respect "if" blocks that are booleans #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR addresses a bug where the
allowForbiddenValuesoption was interfering with boolean conditional evaluation in JSON Schemaifstatements. When boolean literals (trueorfalse) are used as conditions, they should always evaluate consistently regardless of validation options.🐛 Problem Solved
When using boolean literals as conditions in JSON Schema conditionals:
{ "if": true, "then": { "required": ["field1"] }, "else": { "required": ["field2"] } }The
allowForbiddenValuesoption was incorrectly affecting the evaluation of these boolean conditions, leading to unpredictable behavior where:if: truemight not always trigger thethenbranchif: falsemight not always trigger theelsebranchSolution
Enhanced the
evaluateIfConditionfunction to properly handle boolean conditionals:Key Changes:
allowForbiddenValuesoption during evaluationif: truealways evaluates totrue(triggersthenbranch)if: falsealways evaluates tofalse(triggerselsebranch)allowForbiddenValuesoption normally