-
Notifications
You must be signed in to change notification settings - Fork 18
fix: allow for computed values to be used inside conditionals #215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
antoniocapelo
merged 12 commits into
main
from
devxp-3278-allow-for-const-validation-against-json-logic-validatio
Jul 22, 2025
Merged
fix: allow for computed values to be used inside conditionals #215
antoniocapelo
merged 12 commits into
main
from
devxp-3278-allow-for-const-validation-against-json-logic-validatio
Jul 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragidavid
reviewed
Jul 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment or 2, otherwise its pretty solid imo!
|
@dragidavid can I get a re-review? |
dragidavid
approved these changes
Jul 22, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments! All good 👌
…t-json-logic-validatio
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Allow computed values to work within conditional schema structures
Problem
Computed values from JSON Logic (
x-jsf-logic-computedAttrs) were not being properly applied when used inside conditional schema structures likeif/then/elsestatements andallOf/anyOfcompositions. This prevented dynamic schema modifications based on computed values within these conditional contexts.Solution
cycleThroughPropertiesAndApplyValuesto recursively process computed values withinif,allOf, andanyOfschema structuresChanges
src/validation/json-logic.ts: Extended the computed values processing to handle conditional schemas (if,allOf,anyOf)src/mutations.ts: Added re-application of schema rules after computed values are applied to ensure proper field updatessrc/types.ts: Updated comment style for consistencytest/validation/json-logic.test.ts: Added test case demonstrating computed values working within conditional statements