Skip to content

Conversation

@sandrina-p
Copy link
Collaborator

Follow-up of #211, comment:

note: Now looking back I'd have called this v0Support instead of ValidationOptions. This is where we'd also pass any config to still support deprecated features.

Another one that comes to my mind is dropping type attr in favor of of inputType. If we have done that already, then it would look like this:

const form = createHeadlessForm(schema, {
  v0Support: {
      includeTypeAttr: true,
  }
}

@antoniocapelo
Copy link
Collaborator

@sandrina-p I'm a bit uncertain about the v0Support name… let's imagine we want to keep this option on a future version. Imagine we introduce a breaking change next week, and we'll be on v2 — having v0Support in it will look off.

Can we find a better name? Maybe Options + the new JSDoc comments you added mentioning v0 is enough?

Copy link
Collaborator

@antoniocapelo antoniocapelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sandrina-p sandrina-p changed the title fix: rename validationOptions to v0support fix: rename validationOptions to legacyOptions Jul 15, 2025
@sandrina-p sandrina-p merged commit 3cd3c3c into main Jul 15, 2025
5 checks passed
@sandrina-p sandrina-p deleted the v1-validationOptions-rename-to-v0Support branch July 15, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants