-
Notifications
You must be signed in to change notification settings - Fork 19
feat: allowing x-jsf-logic to affect field attributes #179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e05a913 to
37c7950
Compare
… schema manipulation
37c7950 to
f01bb59
Compare
antoniocapelo
commented
May 26, 2025
dragidavid
reviewed
May 26, 2025
Collaborator
dragidavid
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @antoniocapelo - left a few comments!
Took me some time but couldn't see anything major! Good stuff!
Collaborator
|
Seems good to me! We'll find out soon enough if I missed anything here 😅 ✅ |
dragidavid
approved these changes
May 26, 2025
eng-almeida
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
This PR aims to allow
x-jsf-logicschema to affect properties of fields.Approach
After a brainy convo with @lukad we decided on a new approach to this:
validateJsonLogicComputedValuesvalidation — since the schema has now the correct values in place, it can operate as with any other schema (hence some code being removed!)Note for reviewers
You'll see more than a 1000 lines being added but this is because I ported all json-logic tests (and their fixtures) from v0 codebase. Please skip reviewing them as they're a copy-paste from v0 (except the part where I removed some of the tests as they were testing unused features that we dropped for v1)
Some examples that should work