-
Notifications
You must be signed in to change notification settings - Fork 19
feat(next): group-array field support #177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… group arrays don't work yet
This also simplifies field generation a bit by removing the object special case as well as the array special case which
41d63be to
541f8ee
Compare
Co-authored-by: Sandrina Pereira <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work @lukad! Everything seems to work fine, I'm still testing against the internal MR, but so far, so good! Let's release anoter dev to run against E2E and then we can merge this ⚡
99e04e1 to
cbafae9
Compare
|
To explain the last 2 commits:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a final test with the new dev versions and it seems to be all good! Approving ✅
This adds support for generating fields for
{"type":"array"}schemas which includes:itemssubschema is anobjectschema)itemssubschema is anything else e.g.{"type": "array", "items": {"type": "string}}