Skip to content

Conversation

@lukad
Copy link
Collaborator

@lukad lukad commented May 2, 2025

This adds support for generating fields for {"type":"array"} schemas which includes:

  • group-arrays (an array schema where the items subschema is an object schema)
  • array schemas where the items subschema is anything else e.g. {"type": "array", "items": {"type": "string}}

@lukad lukad changed the title initial group-array field support feat(next): group-array field support May 8, 2025
lukad added 2 commits May 8, 2025 17:43
This also simplifies field generation a bit by removing the object
special case as well as the array special case which
@lukad lukad force-pushed the devxp-2540-group-array-fields branch from 41d63be to 541f8ee Compare May 8, 2025 15:44
@lukad lukad marked this pull request as ready for review May 9, 2025 15:32
@lukad lukad requested review from dragidavid and eng-almeida May 9, 2025 15:32
@lukad lukad requested review from eng-almeida and sandrina-p May 12, 2025 16:08
sandrina-p
sandrina-p previously approved these changes May 13, 2025
Copy link
Collaborator

@sandrina-p sandrina-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work @lukad! Everything seems to work fine, I'm still testing against the internal MR, but so far, so good! Let's release anoter dev to run against E2E and then we can merge this ⚡

@lukad lukad requested a review from sandrina-p May 13, 2025 14:31
@lukad lukad force-pushed the devxp-2540-group-array-fields branch from 99e04e1 to cbafae9 Compare May 13, 2025 15:53
@lukad lukad requested a review from sandrina-p May 14, 2025 08:22
@dragidavid
Copy link
Collaborator

To explain the last 2 commits:

  • I released a new dev version for v0 as we needed the schema updates but the version should remain on the beta as it was before

Copy link
Collaborator

@dragidavid dragidavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a final test with the new dev versions and it seems to be all good! Approving ✅

@sandrina-p sandrina-p merged commit e32f69b into main May 14, 2025
5 checks passed
@sandrina-p sandrina-p deleted the devxp-2540-group-array-fields branch May 14, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants