feat(next): implement file validation #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Leaving this as draft for now since even though file validation works across the board, it causes some regression with the test suite we run against. Digging.. |
antoniocapelo
requested changes
Apr 22, 2025
There was a problem hiding this comment.
Nice job here!
Most of the code looks good and from the testing it's also working nicely. I've left:
- some minor comments, not blockers
- a suggestion for refactoring and simplifying the type validation logic (can be done separately)
- a blocker comment about keeping the consistency on how we call the individual validator functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the missing file validation. This is not really related to json schema in general but more just something that we support with jsf.
The goal was to mimic what we do in v0 and to make the failing tests pass.