Skip to content

Improved absolute redirect url detection in actions/loaders #9829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 11, 2023
Merged

Improved absolute redirect url detection in actions/loaders #9829

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fdc6dfe
Improved absolute redirect url detection in actions/loaders
lkwr Jan 7, 2023
de0c1f5
Signed CLA
lkwr Jan 7, 2023
742d2b8
add additional redirect urls to router test
lkwr Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@
- latin-1
- lequangdongg
- liuhanqu
- lkwr
- lopezac
- lordofthecactus
- loun4
Expand Down
2 changes: 2 additions & 0 deletions packages/router/__tests__/router-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10673,6 +10673,8 @@ describe("a router", () => {
"https://remix.run/blog",
"//remix.run/blog",
"app://whatever",
"mailto:[email protected]",
"web+remix:whatever",
];

for (let url of urls) {
Expand Down
3 changes: 1 addition & 2 deletions packages/router/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2683,8 +2683,7 @@ async function callLoaderOrAction(
"Redirects returned/thrown from loaders/actions must have a Location header"
);

let isAbsolute =
/^[a-z+]+:\/\//i.test(location) || location.startsWith("//");
let isAbsolute = /^(?:[a-z][a-z0-9+.-]*:|\/\/)/i.test(location);

// Support relative routing in internal redirects
if (!isAbsolute) {
Expand Down