Skip to content

feat(router): add optional generic Data type to DeferredData #9642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

feat(router): add optional generic Data type to DeferredData #9642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8dabc90
Update utils.ts
bennyk8y Nov 27, 2022
40ef2f8
Update contributors.yml
bennyk8y Nov 27, 2022
e0785b6
Update packages/router/utils.ts
bennyk8y Dec 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions contributors.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,3 +144,4 @@
- xavier-lc
- xcsnowcity
- yuleicul
- bennyk8y
6 changes: 3 additions & 3 deletions packages/router/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1047,15 +1047,15 @@ export interface TrackedPromise extends Promise<any> {

export class AbortedDeferredError extends Error {}

export class DeferredData {
export class DeferredData<Data extends Record<string, unknown> = Record<string, unknown>> {
private pendingKeys: Set<string | number> = new Set<string | number>();
private controller: AbortController;
private abortPromise: Promise<void>;
private unlistenAbortSignal: () => void;
private subscriber?: (aborted: boolean) => void = undefined;
data: Record<string, unknown>;
data: Data;

constructor(data: Record<string, unknown>) {
constructor(data: Data) {
invariant(
data && typeof data === "object" && !Array.isArray(data),
"defer() only accepts plain objects"
Expand Down