Skip to content

Conversation

@jrakotoharisoa
Copy link
Contributor

@jrakotoharisoa jrakotoharisoa commented Sep 23, 2022

This pull request is a fix for issue #9333

It removes the action data after a redirect from action.

@changeset-bot
Copy link

changeset-bot bot commented Sep 23, 2022

🦋 Changeset detected

Latest commit: 53d58dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Patch
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 23, 2022

Hi @jrakotoharisoa,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 23, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try to do this in completeNavigation to avoid multiple calls of the subscriber. Can you see if the logic for isActionReload can be adjusted to account for this redirect use case? I'm unsure off the top of my head if that has access to enough information to deduce that this was a redirect after a successful action.

Copy link
Contributor Author

@jrakotoharisoa jrakotoharisoa Sep 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I remove this and add a condition to isActionReload to check if navigation location is different from the form action

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brophdawg11, is it better now with the isActionReload logic adjusted ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep - thanks for the changes! I made a small update and added and extra test - I'll get this merged shortly 👍

@brophdawg11 brophdawg11 self-assigned this Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: useActionData return wrong data after redirection from action

3 participants