Skip to content

Allow navigation in child useEffects and fix intermittent issue where browser automation fails to navigate due to race conditions. #8927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 16 commits into from
Closed

Allow navigation in child useEffects and fix intermittent issue where browser automation fails to navigate due to race conditions. #8927

wants to merge 16 commits into from

Conversation

42shadow42
Copy link
Contributor

Fixes #8809

alexlobera and others added 16 commits May 21, 2022 13:01
@alexlobera
docs: fix contributing link (remix-run#8885)
2058362 
* docs: fix contributing link

* chore: add alexlbr to contributors
@tanayv
Docs: Fix typo in getting-started > concepts (remix-run#8888)
c9e6681 
* docs: fix small typo in getting-started > concepts

* Sign CLA: add tanayv to contributors.yml
@remix-cla-bot
chore: sort contributors list
4be7677
@vikingviolinist
Update overview.md (remix-run#8892)
110b924 
* Update overview.md

* Update contributors.yml
@michal-antczak
docs: Add info about changes in matchPath() to upgrading/v5 guide (re…
78c643e 
…mix-run#8894)

* Add info about changes in matchPath() to upgrading v5 guide

* Add signature
@remix-cla-bot
chore: sort contributors list
36f7202
@remix-run-bot
chore: format
381e905
@ryanflorence
chore: added needs-response workflow
715dd23
@ms10596
Update routes.md (remix-run#8910)
cdff394 
* Update routes.md

use-routes instead of use-route

* Update contributors.yml
@remix-cla-bot
chore: sort contributors list
32a3b1a
@xcsnowcity
docs: Update route.md and routes.md (remix-run#8912)
bd95e76 
* Update route.md

change outdated "location" navlink to /utils/location

* Update routes.md

* Update route.md

* Update contributors.yml
@marc2332
docs: Updated TSDoc docs links (remix-run#8913)
9fa54d6 
* Fixed TSDoc docs link for react-router components

* Fixed TSDoc docs link for react-router hooks

* Add missing TSDoc docs link for react-router-dom

* Fixed some TSDoc Docs links on react-router

* Signed CLA
@remix-cla-bot
chore: sort contributors list
a8235dd
@remix-run-bot
chore: format
f3d87dc
@42shadow42
Update hooks.tsx
258b614
@42shadow42
Fix failing tests, and new test cases to expose regression issues wit…
d644b50 
…h useNavigate
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 3, 2022

Hi @42shadow42,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@timdorr
Copy link
Member

timdorr commented Jun 3, 2022

Can you rebase this? I'm seeing a bunch of extra commits here.

@42shadow42
Copy link
Contributor Author

I'm not incredibly familiar with rebasing, I attempted it but it appears to still have extra commits. I'll just open up a new PR with the changes based off dev instead of main.

@42shadow42 42shadow42 closed this Jun 3, 2022
@42shadow42
Copy link
Contributor Author

42shadow42 commented Jun 3, 2022 •
edited
Loading

I cherry-picked my commits onto dev here: #8929

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.