feat: Add Remix Data APIs #8855
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add initial empty history package * feat: add createMemoryHistory + tests * chore: add rollup buld for history * chore: change state type from unknown -> any * feat: Change listen interface to be pop only * chore: fix lint warning * Add history package to yarn workspace * chore: Address PR feedback
Additional notes: - adds unique route id generation to react-router - enhances test harness to manage at navigation level - combines error/catch into a single exception
This one was tricky: - react-router-native used to find the type for URLSearchParams from @types/react-native - The new history work added @types/jsdom - react-router-native now finds that URLSearchParams before the @types/react-native one - the jsdom one imports from the internal built-in TS DOM lib - but it does not include the DOM.Iterable values such as keys See: microsoft/TypeScript#38139
- loader/action - useLoaderData/useActionData/useTransition - exceptionElement/useRouteException - fallbackElement
This reverts commit a887019.
Done in steps via grep/sed: - exceptionElement -> errorElement - useRouteException -> useRouteError - Exception -> Error - exceptions -> errors - exception -> error
feat: change defaultShouldRevalidate from funciton -> boolean chore: simplify revalidation via isRevalidationRequired
Copies the changes from remix remix-run/remix#3094
* feat: add pending logic to NavLink * chore: fixup type imports * chore: add useMemo to nextMatch calculation
Kingdutch
reviewed
May 23, 2022
|
|
||
| export function useFormAction(action = "."): string { | ||
| let routeContext = React.useContext(UNSAFE_RouteContext); | ||
| invariant(routeContext, "useLoaderData must be used inside a RouteContext"); |
There was a problem hiding this comment.
Suggested change
| invariant(routeContext, "useLoaderData must be used inside a RouteContext"); | |
| invariant(routeContext, "useFormAction must be used inside a RouteContext"); |
Drive by comment while looking at the new goodies 🚗
There was a problem hiding this comment.
Thanks! We've rebased this branch so I fixed this over in the new branch 👍
|
Closing to work off the newly rebased branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging the feature branch for https://remix.run/blog/remixing-react-router
@remix-run/routerpackage (with included history APIs)react-routerviaDataMemoryRouterand associated hooksuseActionDatauseLoaderDatauseMatchesuseNavigationuseRevalidatoruseRouteErroruseRouteLoaderDatareact-router-domviaDataBrowserRouter/DataHashRouter, plus a few additional components/hooks on top of the above<Form><ScrollRestoration>useFetcher/useFetchersuseSubmit