Skip to content

Conversation

jadlr
Copy link
Contributor

@jadlr jadlr commented Sep 23, 2025

Wanted to install npm install @t3-oss/env-core zod on a new react router project and got greeted with a resolve error:

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: screencast.web@undefined
npm error Found: [email protected]
npm error node_modules/valibot
npm error   valibot@"^0.41.0" from @react-router/[email protected]
npm error   node_modules/@react-router/dev
npm error     dev @react-router/dev@"^7.7.1" from the root project
npm error
npm error Could not resolve dependency:
npm error @t3-oss/env-core@"*" from the root project
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/valibot
npm error   peerOptional valibot@"^1.0.0-beta.7 || ^1.0.0" from @t3-oss/[email protected]
npm error   node_modules/@t3-oss/env-core
npm error     @t3-oss/env-core@"*" from the root project

It seems valibot improved the error messages a little which lead to two failing tests.

This is my first ever contribution to a javascript / typescript repo. Let me know if I've done anything wrong. Feel free to close if this violates any policies.

Copy link

changeset-bot bot commented Sep 23, 2025

🦋 Changeset detected

Latest commit: 75a3062

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 23, 2025

Hi @jadlr,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@jadlr
Copy link
Contributor Author

jadlr commented Sep 23, 2025

I created a changeset for @react-router/dev with a patch bump, but I'm unsure what to do next. Do I just commit the created .md file?

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 23, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@brophdawg11
Copy link
Contributor

I created a changeset for @react-router/dev with a patch bump, but I'm unsure what to do next. Do I just commit the created .md file?

yep!

@jadlr
Copy link
Contributor Author

jadlr commented Sep 24, 2025

Thanks @brophdawg11! Done in 7d3ecd1

@jadlr
Copy link
Contributor Author

jadlr commented Sep 24, 2025

Looking at the lock file it seems some other dependencies were updated even though I only used pnpm up "valibot" 🤔

@MichaelDeBoey MichaelDeBoey added the dependencies Pull requests that update a dependency file label Sep 24, 2025
@remix-run remix-run deleted a comment from Samiullahstanikzai Sep 28, 2025
@brophdawg11
Copy link
Contributor

it seems some other dependencies were updated

I updated so the only changes now are related to valibot 👍

@brophdawg11 brophdawg11 merged commit f7bacc1 into remix-run:dev Oct 1, 2025
7 of 8 checks passed
@jadlr
Copy link
Contributor Author

jadlr commented Oct 1, 2025

Thanks @brophdawg11 ! How did you update valibot in isolation? I used pnpm up "valibot" after I changed the valibot dependency in packages.json to ^1.1.0

@brophdawg11
Copy link
Contributor

I think I just backed out the unrelated changes and ensured that pnpm i --frozen-lockfile still ran without any issues. IIRC, the unrelated changes were mostly around nightly/canary builds of a few unrelated packages.

Copy link
Contributor

github-actions bot commented Oct 6, 2025

🤖 Hello there,

We just published version 7.9.4-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@jadlr
Copy link
Contributor Author

jadlr commented Oct 6, 2025

Thanks for the explanation @brophdawg11 !

Copy link
Contributor

github-actions bot commented Oct 8, 2025

🤖 Hello there,

We just published version 7.9.4 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed dependencies Pull requests that update a dependency file pkg:@react-router/dev

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants