Skip to content

Conversation

brophdawg11
Copy link
Contributor

Copy link

changeset-bot bot commented Jul 7, 2025

🦋 Changeset detected

Latest commit: f621455

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
react-router Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/dev Patch
react-router-dom Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11
Copy link
Contributor Author

@topaxi This fix is available in an experimental release (0.0.0-experimental-8265d95da) if you want to see if that fixes the issue. I'll do some testing on my own as well and look to get this into the next release. The signature is now back to accepting a context object - which should either be an AppLoadContext or an unstable_RouterContextProvider depending on whether you've opted into middleware yet,

@brophdawg11
Copy link
Contributor Author

brophdawg11 commented Jul 7, 2025

Actually - I found a couple small type issues - I'll fix them and kick out a new experimental shortly.

Update: 0.0.0-experimental-f62145588 should be deployed shortly

@MichaelDeBoey MichaelDeBoey changed the title Fix context parameter in createRoutesStub for non-middleware users fix(react-router): fix context parameter in createRoutesStub for non-middleware users Jul 7, 2025
@topaxi
Copy link

topaxi commented Jul 8, 2025

Looks great, thank you for the quick fix! I'll try to take a look this week, but from the changes and the added test, I'm pretty confident this should do.

@brophdawg11 brophdawg11 merged commit a3fc04b into dev Jul 9, 2025
9 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/fix-routes-stub-context branch July 9, 2025 20:29
Copy link
Contributor

🤖 Hello there,

We just published version 7.7.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 7.7.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants