-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
Fix prerender file locations when cwd differs from project root #13824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix prerender file locations when cwd differs from project root #13824
Conversation
🦋 Changeset detectedLatest commit: 542cdb3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Hi @kigawas, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected]. Thanks! - The Remix team |
3d2678f
to
2b15c9f
Compare
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
2b15c9f
to
f14af14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I noticed that in the original logic and your update, we're sometimes using relative paths when writing files to disk. To make this safer, I've updated the logic so absolute paths are always used when writing files, and we only use relative paths when logging the path to the terminal.
40eff89
to
df1d795
Compare
…x-run#13824) Co-authored-by: Mark Dalgleish <[email protected]>
🤖 Hello there, We just published version Thanks! |
Confirmed it's working |
🤖 Hello there, We just published version Thanks! |
Closes #13801