Skip to content

Conversation

kigawas
Copy link
Contributor

@kigawas kigawas commented Jun 18, 2025

Closes #13801

Copy link

changeset-bot bot commented Jun 18, 2025

🦋 Changeset detected

Latest commit: 542cdb3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 18, 2025

Hi @kigawas,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@kigawas kigawas force-pushed the vite/fix-prerender-root-directory branch from 3d2678f to 2b15c9f Compare June 18, 2025 01:49
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 18, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@kigawas kigawas force-pushed the vite/fix-prerender-root-directory branch from 2b15c9f to f14af14 Compare July 1, 2025 11:35
@timdorr timdorr requested a review from markdalgleish July 1, 2025 14:56
Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I noticed that in the original logic and your update, we're sometimes using relative paths when writing files to disk. To make this safer, I've updated the logic so absolute paths are always used when writing files, and we only use relative paths when logging the path to the terminal.

@markdalgleish markdalgleish changed the base branch from main to dev July 7, 2025 01:14
@markdalgleish markdalgleish force-pushed the vite/fix-prerender-root-directory branch from 40eff89 to df1d795 Compare July 7, 2025 01:17
@markdalgleish markdalgleish changed the title fix: vite plugin root directory of prerender Fix prerender file locations when cwd differs from project root Jul 7, 2025
@markdalgleish markdalgleish merged commit 1396c7f into remix-run:dev Jul 7, 2025
8 checks passed
@kigawas kigawas deleted the vite/fix-prerender-root-directory branch July 7, 2025 08:07
vezaynk pushed a commit to vezaynk/react-router that referenced this pull request Jul 7, 2025
Copy link
Contributor

🤖 Hello there,

We just published version 7.7.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@kigawas
Copy link
Contributor Author

kigawas commented Jul 12, 2025

Confirmed it's working

Copy link
Contributor

🤖 Hello there,

We just published version 7.7.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vite plugin outputs prerender files to wrong directory on workerd environment
3 participants