Skip to content

Conversation

MichaelDeBoey
Copy link
Member

Resubmission of @TrySound's remix-run/remix#10199

We use https for development at Webstudio.
While setup we found some requests always have "http" protocol. Turns out origin is not sent with get requests and node-adapter falls back into "http".

Here added https detection based on express internals.

Copy link

changeset-bot bot commented Jun 4, 2025

🦋 Changeset detected

Latest commit: e860d8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title feat(dev/vite): detect HTTPS protocol fix(dev/vite): properly handle https protocol in dev mode Jun 29, 2025
@MichaelDeBoey MichaelDeBoey merged commit 2441c01 into remix-run:dev Jun 29, 2025
8 checks passed
@MichaelDeBoey MichaelDeBoey deleted the detect-HTTPS-protocol branch June 29, 2025 23:35
vezaynk pushed a commit to vezaynk/react-router that referenced this pull request Jul 7, 2025
Copy link
Contributor

🤖 Hello there,

We just published version 7.7.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 7.7.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants