fix(react-router/router): compatible with createRouter where basename does not start with /

[nanianlisao]

I'm not sure if this is a side effect of #8861, it works fine when I use the HashRouter parameter basename as "app1".

So I'm hoping that when I switch to createHashRouter, the basename will still support "app1", rather than requiring me to change it to "/app1".

I sincerely hope that this feature can get your approval.

[changeset-bot]

🦋 Changeset detected

Latest commit: 6c8eaf6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
react-router	Patch
@react-router/architect	Patch
@react-router/cloudflare	Patch
@react-router/dev	Patch
react-router-dom	Patch
@react-router/express	Patch
@react-router/node	Patch
@react-router/serve	Patch
@react-router/fs-routes	Patch
@react-router/remix-routes-option-adapter	Patch
create-react-router	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[remix-cla-bot]

Hi @nanianlisao,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[brophdawg11]

So I'm hoping that when I switch to createHashRouter, the basename will still support "app1", rather than requiring me to change it to "/app1".

Why can't you add the prefix when moving from HashRouter to createHashRouter?

[nanianlisao]

Why can't you add the prefix when moving from HashRouter to createHashRouter?

I'm not creating the routes directly in the front-end code but in an out-of-the-box front-end framework, where the user just passes in some configuration information like basename, and he doesn't care if I pass in createHashRouter or HashRouter.

We have a lot of systems where the basename is passed directly without a "/", which worked fine the way it was before. Now to force the user to change the basename configuration doesn't make as much sense to me, but I don't really want to do additional processing at the framework level, which would complicate everything.

I don't think this is a bug, but hopefully this can be optimized to make createHashRouter compatibility more robust.

[nanianlisao]

@brophdawg11 Any new ideas, I think there is a definite need to keep the createHashRouter API consistent with HashRouter, don't you think?

[brophdawg11]

Oops - sorry this fell through the cracks! Thanks!

[github-actions]

🤖 Hello there,

We just published version 7.8.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

[github-actions]

🤖 Hello there,

We just published version 7.8.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!