Skip to content

Conversation

julienw
Copy link

@julienw julienw commented Feb 13, 2024

This was implemented originally in #10336.

It wasn't clear to me from that PR if fetcher.load itself is stable too, but maybe it is?

Happy to make any needed changes!

@changeset-bot
Copy link

changeset-bot bot commented Feb 13, 2024

⚠️ No Changeset found

Latest commit: f36d28a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Feb 13, 2024

Hi @julienw,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@julienw julienw changed the base branch from main to dev February 13, 2024 15:10
@julienw julienw changed the title Improve the documentation around useFetcher to explain that fetcher.submit is stable across reloads docs: Improve the documentation around useFetcher to explain that fetcher.submit is stable across reloads Feb 13, 2024
@julienw julienw changed the title docs: Improve the documentation around useFetcher to explain that fetcher.submit is stable across reloads docs: Improve the documentation around useFetcher to explain that fetcher.submit is stable across rerenders Feb 13, 2024
…ubmit is stable across rerenders

This was implemented originally in remix-run#10336.
@julienw
Copy link
Author

julienw commented Feb 13, 2024

I'm awaiting the permission to sign the CLA.

@brookslybrand
Copy link
Contributor

Thanks for opening this! Sorry we never merged it in

At this point we're not planning to make updates to the v6 docs unless something is blatantly wrong. These code blocks are more suggestive, not necessarily complete, so I don't think we're going to go back and adjust them at this point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants