Skip to content

Conversation

@brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented Jan 3, 2024

Fix bug where dashes were not picked up as part of the dynamic parameter name:

// A URL `/whatever` should match with `useParams()["foo-bar"] === "whatever"`
let routes = { path: ":foo-bar" };

Without this, the portion after the dash was being incorrectly scored/counted as a static segment, and we only support dynamic parameters as the full URL (#9506)

Closes #11159

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2024

🤖 Hello there,

We just published version 6.21.2-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version 6.21.2 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Routes formatted as $foo-bar are being prioritised over routes formatted as foo-bar.

2 participants