Add generics for Remix type enhancements #10843
Conversation
🦋 Changeset detectedLatest commit: 25622d5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
force-pushed
the
brophdawg11/align-types
branch
from
fef17cb to
ea5a5f2
Compare
| params: AgnosticRouteMatch["params"]; | ||
| data: unknown; | ||
| handle: unknown; | ||
| } |
There was a problem hiding this comment.
This is now exported from utils.ts as UIMatch
|
🤖 Hello there, We just published version Thanks! |
MichaelDeBoey
left a comment
MichaelDeBoey
left a comment
There was a problem hiding this comment.
In the light of named tuple elements, I've seen something passing by to do the same for generic elements as well, so I think it would be better to have long names instead
| * URL path, as well as possibly some arbitrary state and a key. | ||
| */ | ||
| export interface Location extends Path { | ||
| export interface Location<S = any> extends Path { |
There was a problem hiding this comment.
| export interface Location<S = any> extends Path { | |
| export interface Location<State = any> extends Path { |
| * Arguments passed to loader functions | ||
| */ | ||
| export interface LoaderFunctionArgs extends DataFunctionArgs {} | ||
| export interface LoaderFunctionArgs<C = any> extends DataFunctionArgs<C> {} |
There was a problem hiding this comment.
| export interface LoaderFunctionArgs<C = any> extends DataFunctionArgs<C> {} | |
| export interface LoaderFunctionArgs<Context = any> extends DataFunctionArgs<Context> {} |
| * Arguments passed to action functions | ||
| */ | ||
| export interface ActionFunctionArgs extends DataFunctionArgs {} | ||
| export interface ActionFunctionArgs<C = any> extends DataFunctionArgs<C> {} |
There was a problem hiding this comment.
| export interface ActionFunctionArgs<C = any> extends DataFunctionArgs<C> {} | |
| export interface ActionFunctionArgs<Context = any> extends DataFunctionArgs<Context> {} |
| export interface LoaderFunction<C = any> { | ||
| (args: LoaderFunctionArgs<C>): Promise<DataFunctionValue> | DataFunctionValue; |
There was a problem hiding this comment.
| export interface LoaderFunction<C = any> { | |
| (args: LoaderFunctionArgs<C>): Promise<DataFunctionValue> | DataFunctionValue; | |
| export interface LoaderFunction<Context = any> { | |
| (args: LoaderFunctionArgs<Context>): Promise<DataFunctionValue> | DataFunctionValue; |
| export interface ActionFunction<C = any> { | ||
| (args: ActionFunctionArgs<C>): Promise<DataFunctionValue> | DataFunctionValue; |
There was a problem hiding this comment.
| export interface ActionFunction<C = any> { | |
| (args: ActionFunctionArgs<C>): Promise<DataFunctionValue> | DataFunctionValue; | |
| export interface ActionFunction<Context = any> { | |
| (args: ActionFunctionArgs<Context>): Promise<DataFunctionValue> | DataFunctionValue; |
| return matches; | ||
| } | ||
|
|
||
| export interface UIMatch<D = unknown, H = unknown> { |
There was a problem hiding this comment.
| export interface UIMatch<D = unknown, H = unknown> { | |
| export interface UIMatch<Data = unknown, Handle = unknown> { |
| data: D; | ||
| handle: H; |
There was a problem hiding this comment.
| data: D; | |
| handle: H; | |
| data: Data; | |
| handle: Handle; |
|
🤖 Hello there, We just published version Thanks! |
Adding TS generics to support remix-run/remix#7319