Skip to content

Fix pathless relative routing with a basename #10433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2023
Merged

Fix pathless relative routing with a basename #10433

merged 1 commit into from
May 2, 2023

Conversation

@brophdawg11
Copy link
Contributor

@brophdawg11 brophdawg11 commented May 2, 2023

Closes #10431

@changeset-bot
Copy link

changeset-bot bot commented May 2, 2023

🦋 Changeset detected

Latest commit: 55835d7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@remix-run/router Patch
react-router Patch
react-router-dom Patch
react-router-dom-v5-compat Patch
react-router-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@brophdawg11 brophdawg11 linked an issue May 2, 2023 that may be closed by this pull request
[Bug]: Basename is duplicated when calling setSearchParams #10431
Closed
brophdawg11
brophdawg11 commented May 2, 2023
View reviewed changes
packages/router/router.ts
to ? to : ".",
getPathContributingMatches(contextualMatches).map((m) => m.pathnameBase),
location.pathname,
stripBasename(location.pathname, basename) || location.pathname,
Copy link
Contributor Author

@brophdawg11 brophdawg11 May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

useLocation strips this off so this code brought in from the react layer lost that since the raw router location contains the basename

@brophdawg11 brophdawg11 merged commit 290d9e7 into dev May 2, 2023
@brophdawg11 brophdawg11 deleted the brophdawg11/search-params-basename branch May 2, 2023 16:47
@brophdawg11 brophdawg11 mentioned this pull request May 2, 2023
Closed
@github-actions github-actions bot mentioned this pull request May 2, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

🤖 Hello there,

We just published version 6.11.1-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@github-actions github-actions bot mentioned this pull request May 3, 2023
Merged
@github-actions
Copy link
Contributor

github-actions bot commented May 3, 2023

🤖 Hello there,

We just published version 6.11.1 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@soolx
Copy link

soolx commented May 16, 2023

Basename is duplicated when calling useNavigate using 6.11.1, but 6.11.0 is work fine

@brophdawg11
Copy link
Contributor Author

brophdawg11 commented May 16, 2023

Fixed by #10492 - available in 6.11.2-pre.0 currently and should have a stable out this week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacob-ebey jacob-ebey jacob-ebey approved these changes

Assignees

No one assigned

Labels

CLA Signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Basename is duplicated when calling setSearchParams

5 participants

@brophdawg11 @soolx @jacob-ebey @MichaelDeBoey