-
-
Notifications
You must be signed in to change notification settings - Fork 916
Removing linkTarget option
#762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks for the PR! I think this is a good idea. And I’ll be doing a major in a couple weeks. So this is 👍 in my opinion. What do you think, @remcohaszing, @ChristianMurphy? Just jotting down for myself that I should also probably add an example to the readme to show how |
|
Yep, I agree |
ChristianMurphy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a good idea to me as well. 👍
It fits well with the overarching goal of better alignment of this package with the rest of the unified/remark ecosystem.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #762 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 754 733 -21
=========================================
- Hits 754 733 -21 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment has been minimized.
This comment has been minimized.
|
Documentation should really be updated to show specifically how to migrate from I had to figure this out myself. In case anyone is coming here looking for help: Before: <ReactMarkdown linkTarget="_blank">
{yourContent}
</ReactMarkdown>After: import rehypeExternalLinks from 'rehype-external-links'
<ReactMarkdown rehypePlugins={[[rehypeExternalLinks, { target: '_blank' }]]}>
{yourContent}
</ReactMarkdown>Basically Hope that helps someone. |
|
It’s documented https://github.com/remarkjs/react-markdown/releases/tag/9.0.0. |
Initial checklist
Description of changes
Following the discussion in #761, I removed the redundant
linkTargetprop.This functionality can still be applied using plugins, or the
componentsprop.