Skip to content

bump schemars to 1.0 #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bump schemars to 1.0 #174

wants to merge 1 commit into from

Conversation

mdepta42
Copy link

Bump version of schemars to recently released 1.0.

Changes incldue:

  • Module paths updates.
  • Schema definition has been rewritten using json_schema macro.
  • JsonSchema trait definition was changed, most notably is_referenceable has been changed to inline_schema(see and see)
  • tests have been updated to account for new schemas now using serde_json::Value internally see

I'm no expert at the schemars internals so everyone please feel free to correct / improve upon the current implementation.

@mbrubeck
Copy link
Collaborator

Can we keep schemars 0.8 support while adding a separate schemars1 feature, so this is not a breaking change? (Then we can remove the 0.8 support in a future major version.)

Note: The test failures are fixed by #175.

@mdepta42
Copy link
Author

Oh yeah absolutely. An alternative I've been considering is to add support for ordered float over in the schemars crate. They provide support for many common crates, and use the dependency versioning scheme using features you've suggested.

I'm okay with either approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants