Skip to content

Conversation

crgmz
Copy link
Contributor

@crgmz crgmz commented May 16, 2021


name: 📝 Documentation Fix
about: Fixing a problem in an existing docs page

Checklist

  • Is there an existing issue for this PR?
    • link issue here
  • Have the files been linted and formatted?

What docs page needs to be fixed?

  • Section: Detailed Explanation: Thunks and Async Logic
  • Page: Redux Essentials, Part 2: Redux App Structure

What is the problem?

extraArgument is part of the redux-thunk middleware but it's out of context for the purposes of this example.

What changes does this PR make to fix the problem?

Remove the extraArgument to avoid confusion.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 81c8002:

Sandbox Source
Vanilla Configuration
Vanilla Typescript Configuration

@netlify
Copy link

netlify bot commented May 16, 2021

Deploy preview for redux-docs ready!

Built with commit 81c8002

https://deploy-preview-4087--redux-docs.netlify.app

@markerikson
Copy link
Contributor

Yeah, probably not needed there. Thanks!

@markerikson markerikson merged commit e8961bc into reduxjs:master May 16, 2021
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Docs: remove extraArgument from code example
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Docs: remove extraArgument from code example
Former-commit-id: 0ba09f4
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Docs: remove extraArgument from code example
Former-commit-id: 0ba09f4
Former-commit-id: 841b6ce
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Docs: remove extraArgument from code example
Former-commit-id: 0ba09f4
Former-commit-id: 841b6ce
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Docs: remove extraArgument from code example
Former-commit-id: 0ba09f4
Former-commit-id: 841b6ce
webMasterMrBin pushed a commit to webMasterMrBin/redux that referenced this pull request Aug 21, 2021
Docs: remove extraArgument from code example
Former-commit-id: 0ba09f4
Former-commit-id: 841b6ce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants