Skip to content

fix typescript config for rollup #3514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cellog
Copy link
Contributor

@cellog cellog commented Aug 16, 2019

This allows files other than index.ts to be in typescript

@cellog cellog mentioned this pull request Aug 16, 2019
@nickserv
Copy link
Contributor

nickserv commented Aug 17, 2019

As far as I'm aware, we don't need this since the existing Rollup config in ts-conversion already compiles TypeScript to JavaScript. If files other than index.ts aren't working, then ts needs to be added to Rollup's extensions. Types can be checked with npm install, npm publish, or npm run check-types.

@cellog
Copy link
Contributor Author

cellog commented Aug 17, 2019

as much as I would like to not need this, rollup does not recognize import 'blah' if blah is in blah.ts (feel free to prove me wrong, I would much rather not have to do this)

@nickserv
Copy link
Contributor

I fixed this by using rollup-plugin-node-resolve: #3517

@cellog
Copy link
Contributor Author

cellog commented Aug 17, 2019

closing as obsolete, thanks @nickmccurdy !

@cellog cellog closed this Aug 17, 2019
@cellog cellog deleted the cellog-3500-config branch August 17, 2019 04:14
@cellog cellog restored the cellog-3500-config branch August 18, 2019 02:39
@cellog cellog reopened this Aug 18, 2019
@cellog
Copy link
Contributor Author

cellog commented Aug 18, 2019

re-opening, the fix doesn't quite work as the ES and CommonJS builds don't use nodeResolve

@cellog
Copy link
Contributor Author

cellog commented Aug 18, 2019

bye again

@cellog cellog closed this Aug 18, 2019
@cellog cellog deleted the cellog-3500-config branch August 18, 2019 14:56
@cellog cellog restored the cellog-3500-config branch August 19, 2019 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants