Allow React 16 as peerDependency for 4.x #660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yep, no problem. |
|
Oh wait, this is for 4.0. Did those teams run into problems moving to 5.0? I know that might be a bigger ask, but BC should be maintained despite the major bump. |
|
Pushed as 4.4.7 |
|
I don't think we're using 5.x anywhere yet, will raise issues if we find problems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently causing warnings in our React Native builds at Facebook.
Could you please merge this and release a bump?
I could do this myself but I haven't released in a while and don't want to screw up 😛