Allow to fill meta prop of an action
#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I'm thinking we should probably omit it. The action creator may receive something that's not serializable, like a promise. It's easy enough to pass an identity function for those special cases. |
Contributor
Author
|
Ok. I'll change this to omit if it no function is passed asap. |
acdlite
added a commit
that referenced
this pull request
Jul 13, 2015
Allow to fill `meta` prop of an action
Contributor
|
Thanks @johanneslumpe! |
|
Thank you all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #3 and will be useful together with #2.
@acdlite Does it seem logical for you to just use
identityif no meta creator has been passed? Seems better to me than omittingmetain that case.