Add support for jasmine 2.x #34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/jasmine.js
Outdated
| }; | ||
| }; | ||
|
|
||
| const toNotDispatchActions = () => { |
There was a problem hiding this comment.
Would be also nice to add a negative comparison support. See https://jasmine.github.io/2.0/custom_matcher.html#section-Custom_negative_comparators
src/jasmine.js
Outdated
| /* eslint-env jasmine */ | ||
| import { assertions } from 'redux-actions-assertions-js'; | ||
|
|
||
| const toDispatchActions = () => { |
There was a problem hiding this comment.
Please use functions declarations as it is done in other files to keep format consistency
|
|
||
| export { | ||
| registerAssertions, | ||
| matchers |
There was a problem hiding this comment.
Do we need to expose matchers?
There was a problem hiding this comment.
The idea is to import them from Jest and making the registration step more explicit on the jest's setupTestFrameworkScriptFile file (instead of simply calling jasmine's registerAssertions() there)
|
PR updated. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #31