enhancement atomic_pointer #782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kendriyavid, could you resolve those build failures? |
Yeah, I’m on it! This is my first time diving this deep 😅, so I’m learning a lot along the way. I’ll update you soon. |
|
Hi @kendriyavid, I think you should change this as well Line 158 in a4ede68 |
rueian
reviewed
Feb 28, 2025
pipe.go
Outdated
| @@ -118,6 +118,7 @@ func _newPipe(connFn func() (net.Conn, error), option *ClientOption, r2ps, nobg | |||
|
|
|||
| r2ps: r2ps, | |||
| } | |||
| p.error.Store(&errs{}) | |||
There was a problem hiding this comment.
Suggested change
| p.error.Store(&errs{}) |
Adding this is incorrect.
|
Hi @rueian, thanks for the help, now It is passing all the tests |
rueian
approved these changes
Mar 1, 2025
This was referenced Mar 1, 2025
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes error from
atomic.ValuetoAtomic.pointerFixes #776