Add FunctionStats to rueidiscompat #772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented FunctionStats in rueidiscompat to enhance functionality. -Ensured compatibility with existing code and followed project conventions.
rueian
reviewed
Feb 21, 2025
rueidiscompat/command.go
Outdated
| } | ||
|
|
||
| func (cmd *FunctionStatsCmd) from(res rueidis.RedisResult) { | ||
| fstats := new(FunctionStats) |
There was a problem hiding this comment.
Suggested change
| fstats := new(FunctionStats) | |
| var fstats FunctionStats |
rueidiscompat/command.go
Outdated
| case "command": | ||
| val.Command, err = attr.AsStrSlice() | ||
| case "duration_ms": | ||
| ms, err := attr.ToInt64() |
There was a problem hiding this comment.
Suggested change
| ms, err := attr.ToInt64() | |
| ms, err := attr.AsInt64() |
rueidiscompat/command.go
Outdated
| for k, v := range emap { | ||
| switch k { | ||
| case "libraries_count": | ||
| engine.LibrariesCount, err = v.ToInt64() |
There was a problem hiding this comment.
Suggested change
| engine.LibrariesCount, err = v.ToInt64() | |
| engine.LibrariesCount, err = v.AsInt64() |
rueidiscompat/command.go
Outdated
| case "libraries_count": | ||
| engine.LibrariesCount, err = v.ToInt64() | ||
| case "functions_count": | ||
| engine.FunctionsCount, err = v.ToInt64() |
There was a problem hiding this comment.
Suggested change
| engine.FunctionsCount, err = v.ToInt64() | |
| engine.FunctionsCount, err = v.AsInt64() |
rueidiscompat/command.go
Outdated
| case "name": | ||
| val.Name, err = v.ToString() | ||
| case "duration_ms": | ||
| ms, err := v.ToInt64() |
There was a problem hiding this comment.
Suggested change
| ms, err := v.ToInt64() | |
| ms, err := v.AsInt64() |
rueian
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.