add note to CHANGELOG about Ruby 2.4 deprecation warnings #677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Not a feature or bug fix. Thanks. |
|
@djanowski I think this should have been pulled in. I was looking for exactly this line in the changelog and didn't find it, so I started searching through the issues after Changelogs are written for humans, sometimes information that isn't directly related to a feature or bug can still be included because it's useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that as of 3.3.3, redis-rb no longer raises deprecation warnings on
Ruby 2.4 related to Fixnum etc (see #660), but the CHANGELOG doesn't reflect
this.
Updated the changelog with the new info ;)