Skip to content

Add Redis::Distributed#mget #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add Redis::Distributed#mget #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4e82e5
Add support for MGET to Redis::Distributed.
tompave Jan 26, 2017
197d11b
splat the keys
tompave Jan 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/redis/distributed.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,8 +278,18 @@ def get(key)
end

# Get the values of all the given keys.
#
def mget(*keys)
raise CannotDistribute, :mget
m_nodes = keys.group_by { |key| node_for(key) }

results = Hash[
m_nodes.flat_map do |node, key_list|
values = node.mget(*key_list)
key_list.zip(values)
end
]

keys.map { |key| results[key] }
end

def mapped_mget(*keys)
Expand Down
8 changes: 5 additions & 3 deletions test/distributed_commands_on_strings_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,11 @@ class TestDistributedCommandsOnStrings < Test::Unit::TestCase
include Lint::Strings

def test_mget
assert_raise Redis::Distributed::CannotDistribute do
r.mget("foo", "bar")
end
r.set("foo", "s1")
r.set("bar", "s2")

assert_equal ["s1", "s2"] , r.mget("foo", "bar")
assert_equal ["s1", "s2", nil], r.mget("foo", "bar", "baz")
end

def test_mget_mapped
Expand Down