Skip to content

Conversation

vladvildanov
Copy link
Collaborator

Pull Request check-list

Please make sure to review and check all of these items:

  • Do tests and lints pass with this change?
  • Do the CI tests pass with this change (enable it first in your forked repo and wait for the github action build to finish)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?
  • Is there an example added to the examples folder (if applicable)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Description of change

Please provide a description of the change here.

Copy link
Contributor

@elena-kolevska elena-kolevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for a better organisation of the initial part

Copy link
Collaborator

@petyaslavova petyaslavova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The spellcheck action is still failing. Some of the flagged words are standard abbreviations and should be added to the pyspelling.filters.html ignores filter in redis-py/.github/spellcheck-settings.yml.

MultiDBClient explanation
--------------------------

The `MultiDBClient` (introduced in version 6.5.0) manages connections to multiple
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6.5.0 --> 7.0.0 ?

raise NoValidDatabaseException("No available database for failover")

In case if there's no available databases for failover, we raise `TemporaryUnavailableException`.
This exception signals that you can still trying to send requests until final
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can still trying --> you can still continue trying

`NoValidDatabaseException` will be thrown. The window for requests is configurable
and depends on two parameters `failover_attempts` and `failover_delay`. By default,
`failover_attempts=10` and `failover_delay=12s`, which means that you can still send requests
for 10*12 = 120 seconds until final exception will be thrown. In meanwhile, you can switch to
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In meanwhile should be just Meanwhile or In the meantime

and depends on two parameters `failover_attempts` and `failover_delay`. By default,
`failover_attempts=10` and `failover_delay=12s`, which means that you can still send requests
for 10*12 = 120 seconds until final exception will be thrown. In meanwhile, you can switch to
another data source (cache) and if healthy database will apears you can switch back making
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

appears --> appear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants