-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Added documentation for Active-Active #3753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: feat/active-active
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions for a better organisation of the initial part
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The spellcheck action is still failing. Some of the flagged words are standard abbreviations and should be added to the pyspelling.filters.html
ignores filter in redis-py/.github/spellcheck-settings.yml
.
MultiDBClient explanation | ||
-------------------------- | ||
|
||
The `MultiDBClient` (introduced in version 6.5.0) manages connections to multiple |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6.5.0 --> 7.0.0 ?
raise NoValidDatabaseException("No available database for failover") | ||
|
||
In case if there's no available databases for failover, we raise `TemporaryUnavailableException`. | ||
This exception signals that you can still trying to send requests until final |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can still trying --> you can still continue trying
`NoValidDatabaseException` will be thrown. The window for requests is configurable | ||
and depends on two parameters `failover_attempts` and `failover_delay`. By default, | ||
`failover_attempts=10` and `failover_delay=12s`, which means that you can still send requests | ||
for 10*12 = 120 seconds until final exception will be thrown. In meanwhile, you can switch to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In meanwhile
should be just Meanwhile
or In the meantime
and depends on two parameters `failover_attempts` and `failover_delay`. By default, | ||
`failover_attempts=10` and `failover_delay=12s`, which means that you can still send requests | ||
for 10*12 = 120 seconds until final exception will be thrown. In meanwhile, you can switch to | ||
another data source (cache) and if healthy database will apears you can switch back making |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
appears --> appear
Pull Request check-list
Please make sure to review and check all of these items:
NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.
Description of change
Please provide a description of the change here.