Skip to content

Add types to ConnectionPool.from_url #3495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 4, 2025
Merged

Add types to ConnectionPool.from_url #3495

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
30ad99c
Add types to ConnectionPool.from_url
patrick91 Feb 3, 2025
823fca3
Merge branch 'master' into types/connection-pool-from-url
vladvildanov Feb 4, 2025
3f8a40f
Merge branch 'master' into types/connection-pool-from-url
vladvildanov Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions redis/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
from itertools import chain
from queue import Empty, Full, LifoQueue
from time import time
from typing import Any, Callable, Dict, List, Optional, Type, Union
from typing import Any, Callable, Dict, List, Optional, Type, TypeVar, Union
from urllib.parse import parse_qs, unquote, urlparse

from redis.cache import (
Expand Down Expand Up @@ -1263,6 +1263,9 @@ def parse_url(url):
return kwargs


_CP = TypeVar("_CP", bound="ConnectionPool")


class ConnectionPool:
"""
Create a connection pool. ``If max_connections`` is set, then this
Expand All @@ -1278,7 +1281,7 @@ class ConnectionPool:
"""

@classmethod
def from_url(cls, url, **kwargs):
def from_url(cls: Type[_CP], url: str, **kwargs) -> _CP:
"""
Return a connection pool configured from the given URL.

Expand Down
Loading