Create dt_list.py #2855
Merged
Create dt_list.py #2855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add the data type list python code for tabbed examples
Author
|
@uglide and lists! |
r.delete returns zero for an empty list and one for a non-empty - added a delete prior to ensure the delete is always empty and assertion passes
a single example doesn't render correctly if used twice on a webpage so adding a separate ltrim example
uglide
requested changes
Jul 20, 2023
Contributor
uglide
left a comment
uglide
left a comment
There was a problem hiding this comment.
Great work!
We can make this example more concise by explaining List basics around one pattern Producer/Consumer which is extensively covered in the current version of the doc here https://redis.io/docs/data-types/lists/
remove delete cleanups from ever being seen by user
Author
|
@uglide I believe those changes would be better addressed with an issue for the docs team to rework the structure of that content |
Author
|
@chayim if you could take a look! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as part of the effort to get tabbed examples in client languages on the redis.io website, this file contains the examples for the list datatype in python with the appropriate short codes to be pulled in