Skip to content

Async clusters: Support creating locks inside async functions #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2022
Merged

Async clusters: Support creating locks inside async functions #2471

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b32bbb
async_cluster: create asyncio.Lock inside async functions
utkarshgupta137 Nov 24, 2022
f9363db
Merge branch 'master' into async_cluster_lock
chayim Dec 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion redis/asyncio/cluster.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,11 +356,13 @@ def __init__(
)

self._initialize = True
self._lock = asyncio.Lock()
self._lock: Optional[asyncio.Lock] = None

async def initialize(self) -> "RedisCluster":
"""Get all nodes from startup nodes & creates connections if not initialized."""
if self._initialize:
if not self._lock:
self._lock = asyncio.Lock()
async with self._lock:
if self._initialize:
try:
Expand All @@ -378,6 +380,8 @@ async def initialize(self) -> "RedisCluster":
async def close(self) -> None:
"""Close all connections & client if initialized."""
if not self._initialize:
if not self._lock:
self._lock = asyncio.Lock()
async with self._lock:
if not self._initialize:
self._initialize = True
Expand Down