Updating default page size to 1000 from 10 #282
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The default page size for `all` is supposed to be 1000 not 10, for performance reasons. When I changed the constant `DEFAULT_PAGE_SIZE` a while back, I seem to have forgotten to have changed it here. This fixes that.
Codecov Report
@@ Coverage Diff @@
## main #282 +/- ##
==========================================
+ Coverage 77.27% 77.33% +0.06%
==========================================
Files 12 12
Lines 1166 1165 -1
==========================================
Hits 901 901
+ Misses 265 264 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dvora-h
approved these changes
Jul 4, 2022
chayim
changed the title
all()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default page size for
allis supposed to be 1000 not 10, for performance reasons. When I changed the constantDEFAULT_PAGE_SIZEa while back, I seem to have forgotten to have changed it here. This fixes that.